Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

handle ancient overflow case correctly #29458

Merged
merged 1 commit into from
Jan 2, 2023

Conversation

jeffwashington
Copy link
Contributor

@jeffwashington jeffwashington commented Jan 2, 2023

Problem

Ancient append vec overflow was not being handled correctly with shrink_in_progress.
When we continue refactoring shrink, shrink_in_progress will be relied upon solely to determine which append vecs to drop from a slot.
This is tested by test_shrink_ancient_overflow. The test fails once we get rid of should_retain parameter from mark_dirty_dead_stores. At the moment, we are still relying on the append vec ids and should_retain to correctly remove old stores after a shrink.

Summary of Changes

Update shrink_in_progress correctly for ancient append vec overflow case.

Fixes #

@jeffwashington jeffwashington marked this pull request as ready for review January 2, 2023 16:57
Copy link
Contributor

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find. Lgtm

@jeffwashington jeffwashington merged commit e99afb4 into solana-labs:master Jan 2, 2023
gnapoli23 pushed a commit to gnapoli23/solana that referenced this pull request Jan 10, 2023
gnapoli23 pushed a commit to gnapoli23/solana that referenced this pull request Jan 10, 2023
gnapoli23 pushed a commit to gnapoli23/solana that referenced this pull request Jan 10, 2023
gnapoli23 pushed a commit to gnapoli23/solana that referenced this pull request Jan 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants